RFR: 8331094: GTest fails due to incompatible Windows version

Stefan Johansson sjohanss at openjdk.org
Thu Apr 25 09:03:38 UTC 2024


Please review this test fix for an intermittent tier1 failure.

**Summary**
A newly added Windows specific ZGC tests requires some system calls not available on all Windows systems. This fix adds code to the test setup to ensure the required system calls are supported and otherwise skip the test.

**Testing**
Verified that the test is now skipped if running on a system that is not supported. We get the following output: 

[----------] 3 tests from ZMapperTest
[ RUN      ] ZMapperTest.test_alloc_low_address_vm
...\\open\\test\\hotspot\\gtest\\gc\\z\\test_zMapper_windows.cpp(72): Skipped
Requires Windows version 1803 or later

[  SKIPPED ] ZMapperTest.test_alloc_low_address_vm (0 ms)
[ RUN      ] ZMapperTest.test_alloc_high_address_vm
...\\open\\test\\hotspot\\gtest\\gc\\z\\test_zMapper_windows.cpp(72): Skipped
Requires Windows version 1803 or later

[  SKIPPED ] ZMapperTest.test_alloc_high_address_vm (0 ms)
[ RUN      ] ZMapperTest.test_alloc_whole_area_vm
...\\open\\test\\hotspot\\gtest\\gc\\z\\test_zMapper_windows.cpp(72): Skipped
Requires Windows version 1803 or later

-------------

Commit messages:
 - Remove comment and fix typo
 - Add message to GTEST_SKIP
 - 8331094: GTest fails due to incompatible Windows version

Changes: https://git.openjdk.org/jdk/pull/18944/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18944&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8331094
  Stats: 13 lines in 1 file changed: 11 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18944.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18944/head:pull/18944

PR: https://git.openjdk.org/jdk/pull/18944


More information about the hotspot-gc-dev mailing list