RFR: 8330275: Crash in XMark::follow_array [v3]

[Thomas Stuefe]

On Fri, 26 Apr 2024 06:06:03 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> > @stefank I am trying to understand the reason behind your suggestion to remove the changes in marking stack code. Are they not correct or is it that they don't belong to this PR? Anyway I have removed them from this PR.
> 
> To me, it was not bleeding obvious that they were the right thing to do, and given other changes that doesn't follow the grown ZGC coding style, I wanted suggest a way forward for you to get this bug fixed, with less resistance from us ZGC developers/maintainers. That was the reasoning.

I agree with Stefan. I would keep the patch as minimal as possible to make it easier to follow the actual error that has been fixed, and to make it easier for backporters to decide what to downport. 

Code cleanups can happen in a separate RFE.

Ashu, are the other platforms actually broken? If yes, which ones? If a platform is not broken, I would defer touching it up to a separate cleanup RFE. Again because of patch clarity.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18941#issuecomment-2078744978