RFR: 8330275: Crash in XMark::follow_array [v3]

Ashutosh Mehra asmehra at openjdk.org
Thu Apr 25 14:32:37 UTC 2024


On Thu, 25 Apr 2024 06:54:24 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typos
>>   
>>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> Hi @ashu-mehra,
> 
> Thanks for fixing this issue.
> 
> There's a number of changes style changes I would like to make to make sure that the code looks more inline with what the rest of the ZGC code looks like. But before we start with that I would like to request that we skip making the changes to marking stack code and limit the changes to only the probing code. Doing so will make it easier to get this fix reviewed and delivered.

@stefank I am trying to understand the reason behind your suggestion to remove the changes in marking stack code. Are they not correct or is it that they don't belong to this PR?
Anyway I have removed them from this PR.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18941#issuecomment-2077346870


More information about the hotspot-gc-dev mailing list