RFR: 8337981: ShenandoahHeap::is_in should check for alive regions [v2]

[William Kemper]

On Tue, 13 Aug 2024 16:52:48 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Style touchups
>>  - Fixing ShenandoahReferenceProcessor
>>  - Verifier fix
>
> src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp line 64:
> 
>> 62:   void* _interior_loc;
>> 63:   oop _loc;
>> 64:   ReferenceIterationMode _ref_mode;
> 
> I don't see where this new field is read.

Okay, I see now that `reference_iteration_mode` overrides a virtual method defined in `OopIterateClosure`. Perhaps mark it with `override` for readability?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20492#discussion_r1715632948