RFR: 8337981: ShenandoahHeap::is_in should check for alive regions [v2]

Aleksey Shipilev shade at openjdk.org
Wed Aug 14 16:30:54 UTC 2024


On Tue, 13 Aug 2024 16:57:26 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp line 64:
>> 
>>> 62:   void* _interior_loc;
>>> 63:   oop _loc;
>>> 64:   ReferenceIterationMode _ref_mode;
>> 
>> I don't see where this new field is read.
>
> Okay, I see now that `reference_iteration_mode` overrides a virtual method defined in `OopIterateClosure`. Perhaps mark it with `override` for readability?

Right. Since `override` is all-or-nothing, I had to add it to other methods as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20492#discussion_r1717234461


More information about the hotspot-gc-dev mailing list