RFR: 8338490: Serial: Move Generation::print_on to subclasses

[Guoxiong Li]

On Fri, 16 Aug 2024 07:07:36 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Trivial inlining a virtual method to subclasses and some cleanup to related methods.
> 
> The gc-log is slightly updated due to the change of the name of generations. Log before&after shown below:
> 
> 
> # baseline
> 
> [2.417s][debug][gc,heap] GC(0)  def new generation   total 153600K, used 76645K [0x000000060d800000, 0x0000000617ea0000, 0x00000006b3aa0000)
> [2.417s][debug][gc,heap] GC(0)   eden space 136576K,  56% used [0x000000060d800000, 0x00000006122d9538, 0x0000000615d60000)
> [2.417s][debug][gc,heap] GC(0)   from space 17024K,   0% used [0x0000000615d60000, 0x0000000615d60000, 0x0000000616e00000)
> [2.417s][debug][gc,heap] GC(0)   to   space 17024K,   0% used [0x0000000616e00000, 0x0000000616e00000, 0x0000000617ea0000)
> [2.417s][debug][gc,heap] GC(0)  tenured generation   total 341376K, used 0K [0x00000006b3aa0000, 0x00000006c8800000, 0x0000000800000000)
> [2.417s][debug][gc,heap] GC(0)    the space 341376K,   0% used [0x00000006b3aa0000, 0x00000006b3aa0000, 0x00000006c8800000)
> 
> # new
> 
> [9.846s][debug][gc,heap] GC(0)  DefNew     total 153600K, used 71165K [0x000000060d800000, 0x0000000617ea0000, 0x00000006b3aa0000)
> [9.846s][debug][gc,heap] GC(0)   eden space 136576K,  52% used [0x000000060d800000, 0x0000000611d7f708, 0x0000000615d60000)
> [9.846s][debug][gc,heap] GC(0)   from space 17024K,   0% used [0x0000000615d60000, 0x0000000615d60000, 0x0000000616e00000)
> [9.846s][debug][gc,heap] GC(0)   to   space 17024K,   0% used [0x0000000616e00000, 0x0000000616e00000, 0x0000000617ea0000)
> [9.846s][debug][gc,heap] GC(0)  Tenured    total 341376K, used 0K [0x00000006b3aa0000, 0x00000006c8800000, 0x0000000800000000)
> [9.846s][debug][gc,heap] GC(0)   the space 341376K,   0% used [0x00000006b3aa0000, 0x00000006b3aa0000, 0x00000006c8800000)

src/hotspot/share/gc/serial/tenuredGeneration.cpp line 452:

> 450:                p2i(_virtual_space.high_boundary()));
> 451: 
> 452:   st->print("  the");

The new `st->print("  the");` (new line 452) misses one space. Please note the old line (old line 444) has three spaces. Is it your intention?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20607#discussion_r1722944590