RFR: 8338490: Serial: Move Generation::print_on to subclasses [v2]

Albert Mingkun Yang ayang at openjdk.org
Tue Aug 20 09:16:20 UTC 2024


On Tue, 20 Aug 2024 08:53:38 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/gc/serial/tenuredGeneration.cpp line 452:
> 
>> 450:                p2i(_virtual_space.high_boundary()));
>> 451: 
>> 452:   st->print("  the");
> 
> The new `st->print("  the");` (new line 452) misses one space. Please note the old line (old line 444) has three spaces. Is it your intention?

It was intentional, to make sure `the` is not indented too much. Now that I realize that using three-space was to align "space" in those log line. Reverted.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20607#discussion_r1722975505


More information about the hotspot-gc-dev mailing list