RFR: 8345173: BlockLocationPrinter::print_location misses a ResourceMark

Thomas Schatzl tschatzl at openjdk.org
Mon Dec 2 06:35:41 UTC 2024


On Fri, 29 Nov 2024 13:53:19 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> Hi all,
>> 
>>   please review this small change that adds a missing `ResourceMark` to `BlockLocationPrinter`; it can be called at very arbitrary places (e.g. the stop() method of MacroAssembler), and without this change it might fail with a "Missing ResourceMark error - possible memory leak" error instead of providing the stop() output (and then faiiling).
>> 
>> Testing: local testing, after the change the ResourceMark crash goes away, gha
>> 
>> Thanks,
>>   Thomas
>
> Marked as reviewed by sjohanss (Reviewer).

Thanks @kstefanj @walulyai for your reviews

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22455#issuecomment-2510688071


More information about the hotspot-gc-dev mailing list