Integrated: 8345173: BlockLocationPrinter::print_location misses a ResourceMark
Thomas Schatzl
tschatzl at openjdk.org
Mon Dec 2 06:35:42 UTC 2024
On Fri, 29 Nov 2024 09:36:16 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> please review this small change that adds a missing `ResourceMark` to `BlockLocationPrinter`; it can be called at very arbitrary places (e.g. the stop() method of MacroAssembler), and without this change it might fail with a "Missing ResourceMark error - possible memory leak" error instead of providing the stop() output (and then faiiling).
>
> Testing: local testing, after the change the ResourceMark crash goes away, gha
>
> Thanks,
> Thomas
This pull request has now been integrated.
Changeset: f5ebda43
Author: Thomas Schatzl <tschatzl at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/f5ebda43709984214a25e23926860fea2ba5819a
Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
8345173: BlockLocationPrinter::print_location misses a ResourceMark
Reviewed-by: sjohanss, iwalulya
-------------
PR: https://git.openjdk.org/jdk/pull/22455
More information about the hotspot-gc-dev
mailing list