RFR: 8346139: test_memset_with_concurrent_readers.cpp should not use <sstream>

Thomas Schatzl tschatzl at openjdk.org
Fri Dec 13 08:18:35 UTC 2024


On Fri, 13 Dec 2024 00:22:28 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change to test_memset_with_concurrent_readers.cpp to use
> HotSpot's stringStream instead of std::string_stream to build the error
> message when a failure is detected.
> 
> Also removed the include of <string.h>, which is one of the standard headers
> we expect to be included by globalDefinitions.
> 
> Testing: mach5 tier1
> Locally patched the test to fail and ran it, checking the output.

Marked as reviewed by tschatzl (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22725#pullrequestreview-2501681289


More information about the hotspot-gc-dev mailing list