Integrated: 8346139: test_memset_with_concurrent_readers.cpp should not use <sstream>

Kim Barrett kbarrett at openjdk.org
Sat Dec 14 01:51:43 UTC 2024


On Fri, 13 Dec 2024 00:22:28 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change to test_memset_with_concurrent_readers.cpp to use
> HotSpot's stringStream instead of std::string_stream to build the error
> message when a failure is detected.
> 
> Also removed the include of <string.h>, which is one of the standard headers
> we expect to be included by globalDefinitions.
> 
> Testing: mach5 tier1
> Locally patched the test to fail and ran it, checking the output.

This pull request has now been integrated.

Changeset: ebb27c2e
Author:    Kim Barrett <kbarrett at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/ebb27c2e8f47d35d4f030cca4126c39e24d456bd
Stats:     23 lines in 1 file changed: 2 ins; 6 del; 15 mod

8346139: test_memset_with_concurrent_readers.cpp should not use <sstream>

Reviewed-by: stefank, tschatzl

-------------

PR: https://git.openjdk.org/jdk/pull/22725


More information about the hotspot-gc-dev mailing list