RFR: 8324817: Parallel GC does not pre-touch all heap pages when AlwaysPreTouch enabled and large page disabled [v4]

[Wang Zhuo]

On Wed, 31 Jan 2024 12:38:55 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Wang Zhuo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove printings and move necessary information into assertion.
>
> test/hotspot/jtreg/gc/parallel/TestAlwaysPreTouchBehavior.java line 72:
> 
>> 70:         } catch (Exception e) {
>> 71:            return EXCEPTION_VALUE;
>> 72:         }
> 
> This is identical to what caller does. I believe try-catch can be omitted in this method (callee), and keep the only the try-catch in the caller.

Thanks. Redundant try-catch removed.

> test/hotspot/jtreg/gc/parallel/TestAlwaysPreTouchBehavior.java line 78:
> 
>> 76:     long rss = 0;
>> 77:     Runtime runtime = Runtime.getRuntime();
>> 78:     long committedMemory = (runtime.totalMemory()) / 1024; // in kb
> 
> The `()` seems not needed. Also, one doesn't need introduce a tmp `runtime` var.

Redundant () removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17610#discussion_r1473755417
PR Review Comment: https://git.openjdk.org/jdk/pull/17610#discussion_r1473755593