RFR: 8324817: Parallel GC does not pre-touch all heap pages when AlwaysPreTouch enabled and large page disabled [v4]
Wang Zhuo
wzhuo at openjdk.org
Thu Feb 1 03:41:01 UTC 2024
On Wed, 31 Jan 2024 12:42:04 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Wang Zhuo has updated the pull request incrementally with one additional commit since the last revision:
>>
>> remove printings and move necessary information into assertion.
>
> test/hotspot/jtreg/gc/parallel/TestAlwaysPreTouchBehavior.java line 29:
>
>> 27: * @test TestAlwaysPreTouchBehavior
>> 28: * @summary Tests AlwaysPreTouch Bahavior, pages of java heap should be pretouched with AlwaysPreTouch enabled. This test reads RSS of test process, which should be bigger than heap size(1g) with AlwaysPreTouch enabled.
>> 29: * @requires vm.gc.Serial & os.family == "linux" & os.maxMemory > 2G
>
> It should be Parallel, not Serial. The GC requirement should probably be on its own line to distinguish btw `vm` and `os` constraint..
That a real problem. Serial was changed to Parallel in a separate line.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17610#discussion_r1473757038
More information about the hotspot-gc-dev
mailing list