RFR: 8324649: Shenandoah: refactor implementation of free set [v6]

[Kelvin Nilsen]

On Sat, 3 Feb 2024 08:08:34 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename and comments for _capacity_of and _used_by
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 287:
> 
>> 285:   _leftmosts_empty[which_partition] = _max;
>> 286:   _rightmosts_empty[which_partition] = 0;
>> 287:   return 0;
> 
> To my earlier comment of using `ssize_t`, that would allow us to signal failure here by returning a -1.

In the interest of stability, I'm inclined to leave this convention as is.  Could be persuaded to make the change, but there are probably more than 5 touchpoints that also need to be changed (all invocations, existing documentation, etc.)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1477090051