RFR: 8324649: Shenandoah: refactor implementation of free set [v6]

Y. Srinivas Ramakrishna ysr at openjdk.org
Mon Feb 5 15:15:08 UTC 2024


On Sat, 3 Feb 2024 16:28:43 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 287:
>> 
>>> 285:   _leftmosts_empty[which_partition] = _max;
>>> 286:   _rightmosts_empty[which_partition] = 0;
>>> 287:   return 0;
>> 
>> To my earlier comment of using `ssize_t`, that would allow us to signal failure here by returning a -1.
>
> In the interest of stability, I'm inclined to leave this convention as is.  Could be persuaded to make the change, but there are probably more than 5 touchpoints that also need to be changed (all invocations, existing documentation, etc.)

That sounds reasonable; can be addressed later.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1478408600


More information about the hotspot-gc-dev mailing list