RFR: 8324649: Shenandoah: refactor implementation of free set [v6]

[Kelvin Nilsen]

On Thu, 1 Feb 2024 03:01:08 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename and comments for _capacity_of and _used_by
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 171:
> 
>> 169: };
>> 170: 
>> 171: class ShenandoahFreeSet : public CHeapObj<mtGC> {
> 
> It would be good to have a block comment here motivating this class.
> It seems (from looking at some of its public APIs) as if it publicly exports only the "mutator view", which I find interesting.
> 
> The other partitions in `ShenandoahRegionPartition` appears to be for efficiency of the implementation in service of the public APIs for ShenandoahFreeSet.

Thanks.  I've added a block comment to describe ShenandoahFreeSet and have enhanced the comment that describes ShenandoahRegionPartition.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1482087963