RFR: 8324649: Shenandoah: refactor implementation of free set [v6]
Y. Srinivas Ramakrishna
ysr at openjdk.org
Fri Feb 9 09:21:05 UTC 2024
On Wed, 7 Feb 2024 20:58:35 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 171:
>>
>>> 169: };
>>> 170:
>>> 171: class ShenandoahFreeSet : public CHeapObj<mtGC> {
>>
>> It would be good to have a block comment here motivating this class.
>> It seems (from looking at some of its public APIs) as if it publicly exports only the "mutator view", which I find interesting.
>>
>> The other partitions in `ShenandoahRegionPartition` appears to be for efficiency of the implementation in service of the public APIs for ShenandoahFreeSet.
>
> Thanks. I've added a block comment to describe ShenandoahFreeSet and have enhanced the comment that describes ShenandoahRegionPartition.
This is great, thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1484058472
More information about the hotspot-gc-dev
mailing list