RFR: 8324649: Shenandoah: refactor implementation of free set [v6]

Kelvin Nilsen kdnilsen at openjdk.org
Wed Feb 7 21:18:58 UTC 2024


On Thu, 1 Feb 2024 02:39:33 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename and comments for _capacity_of and _used_by
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 187:
> 
>> 185:   // regions.
>> 186:   //
>> 187:   // Precondition: req.size() > ShenandoahHeapRegion::humongous_threshold_words().
> 
> `>` or `>=` ?

>.  See the only invocation from ShenandoahFreeSet::allocate().

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1482106597


More information about the hotspot-gc-dev mailing list