RFR: 8325517: Shenandoah: Reduce unnecessary includes from shenandoahControlThread.cpp

William Kemper wkemper at openjdk.org
Thu Feb 8 19:35:03 UTC 2024


On Thu, 8 Feb 2024 18:43:08 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> The control thread used to run much more of the cycle directly. This code was all factored out into different classes, but many of the vestigial headers remained. Removing these improves compilation times and makes maintenance easier.
>
> src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp line 47:
> 
>> 45: #include "memory/metaspaceStats.hpp"
>> 46: #include "memory/universe.hpp"
>> 47: #include "runtime/atomic.hpp"
> 
> `Atomic` is directly used, so the include should be left here.

Yes, sorry. The branch I cherry-picked from no longer uses `Atomic` directly. I'll put it back.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17778#discussion_r1483501194


More information about the hotspot-gc-dev mailing list