RFR: 8325517: Shenandoah: Reduce unnecessary includes from shenandoahControlThread.cpp
William Kemper
wkemper at openjdk.org
Thu Feb 8 19:53:04 UTC 2024
On Thu, 8 Feb 2024 18:40:31 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> The control thread used to run much more of the cycle directly. This code was all factored out into different classes, but many of the vestigial headers remained. Removing these improves compilation times and makes maintenance easier.
>
> src/hotspot/share/gc/shenandoah/shenandoahUtils.hpp line 46:
>
>> 44:
>> 45:
>> 46: enum StringDedupMode {
>
> I think the only use is in `ShenandoahMark`, right? Therefore, this declaration should go to `shenandoahMark.hpp`, so we do not have to include `shenandoahUtils.hpp` there?
Yes, this is better.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17778#discussion_r1483517109
More information about the hotspot-gc-dev
mailing list