RFR: 8325202: gc/g1/TestMarkStackOverflow.java intermittently crash: G1CMMarkStack::ChunkAllocator::allocate_new_chunk [v2]

Ivan Walulya iwalulya at openjdk.org
Tue Feb 20 14:06:54 UTC 2024


On Tue, 20 Feb 2024 13:56:00 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Ivan Walulya has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Thomas Review
>
> src/hotspot/share/gc/g1/g1ConcurrentMark.cpp line 159:
> 
>> 157:         return nullptr;
>> 158:       }
>> 159:     }
> 
> As I understand it, the issue is that `expand` doesn't guarantee that `_buckets[bucket]` is filled. What do you think of the idea of using a `while` loop here? (one doesn't need a new API and the `*2` logic stays centralized.

I prefer a thread expands to the required capacity instead of the expansion that doesn't consider the thread context.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17912#discussion_r1495878030


More information about the hotspot-gc-dev mailing list