RFR: 8326688: Parallel: Remove unnecessary BOT update in UpdateOnlyClosure::do_addr

[Albert Mingkun Yang]

On Thu, 29 Feb 2024 08:02:45 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Simple removing redundant BOT updates for non-moved objs.
>> 
>> Test: tier1-3
>
> src/hotspot/share/gc/parallel/psParallelCompact.cpp line 2554:
> 
>> 2552: 
>> 2553: inline void UpdateOnlyClosure::do_addr(HeapWord* addr) {
>> 2554:   _start_array->update_for_block(addr, addr + cast_to_oop(addr)->size());
> 
> The change looks reasonable. Instead of the update, would it be possible to do verification in debug mode?

Currently, BOT entries are verified on-update, the last statement of `update_for_block_work`. In my experience, they are rarely corrupted.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18008#discussion_r1507317415