RFR: 8322537: Parallel: Remove experimental adjustment in PSAdaptiveSizePolicy
Albert Mingkun Yang
ayang at openjdk.org
Tue Jan 2 09:34:48 UTC 2024
On Thu, 21 Dec 2023 14:16:25 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Removing this setter (and other similar ones) changes the values of the externally observable performance counters. Not sure if this has been intended.
Yes, that is intended. That perf-counter lives in the "unstable and unsupported name space" (https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/perfData.cpp#L56).
Having the indicated action recorded in the perf-counter was probably used to aid the development of AdaptiveSizePolicy. However, its existence solely complicates the flow nowadays. Therefore, I propose removing it completely. (Ofc, one can always perform another round of experiment to improve AdaptiveSizePolicy afterwards.)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17166#discussion_r1439277814
More information about the hotspot-gc-dev
mailing list