RFR: 8322296: Introduce CardWord for word iteration on CardTable [v3]
Albert Mingkun Yang
ayang at openjdk.org
Tue Jan 2 09:29:47 UTC 2024
On Fri, 22 Dec 2023 01:26:11 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> I find that too "caller-specific" to be included inside `CardTable`. Creating an abstraction here breaks the flow, so I kept it as is.
>
> CardTable is providing CardWord and is_word_aligned (or whatever it gets called), so a function for
> obtaining a CardWord from the CardTable seems entirely reasonable.
In this context, both retrieving card-value and word-value is done via explicit dereference. Packaging only one up destroys the symmetry, and would force future readers to look up the impl on trying to follow the logic here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17144#discussion_r1439273926
More information about the hotspot-gc-dev
mailing list