RFR: 8233443: G1 DetailedUsage class names overly generic for global namespace

Thomas Schatzl tschatzl at openjdk.org
Tue Jan 9 13:31:32 UTC 2024


On Fri, 22 Dec 2023 15:47:02 GMT, Lei Zaakjyu <duke at openjdk.org> wrote:

> Description:
> The classes DetailedUsage and DetailedUsageClosure are defined in G1HeapTransitions.cpp. These class names seem a bit generic for the global namespace. They could be G1-prefixed, but I think better would be to make them nested classes of G1HeapTransition. Just declare them in that class, with the definitions still in the .cpp file.

Lgtm.

(let's give it a try, but I think it won't work :) )

-------------

Marked as reviewed by tschatzl (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17186#pullrequestreview-1811144761
PR Comment: https://git.openjdk.org/jdk/pull/17186#issuecomment-1883051044


More information about the hotspot-gc-dev mailing list