Integrated: 8233443: G1 DetailedUsage class names overly generic for global namespace

Lei Zaakjyu duke at openjdk.org
Tue Jan 9 13:31:33 UTC 2024


On Fri, 22 Dec 2023 15:47:02 GMT, Lei Zaakjyu <duke at openjdk.org> wrote:

> Description:
> The classes DetailedUsage and DetailedUsageClosure are defined in G1HeapTransitions.cpp. These class names seem a bit generic for the global namespace. They could be G1-prefixed, but I think better would be to make them nested classes of G1HeapTransition. Just declare them in that class, with the definitions still in the .cpp file.

This pull request has now been integrated.

Changeset: ff499ef7
Author:    Lei Zaakjyu <lizbing07734 at icloud.com>
Committer: Thomas Schatzl <tschatzl at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/ff499ef79f6bffe95afa17a9aa312ac9f67fba18
Stats:     5 lines in 2 files changed: 3 ins; 0 del; 2 mod

8233443: G1 DetailedUsage class names overly generic for global namespace

Reviewed-by: ayang, gli, tschatzl

-------------

PR: https://git.openjdk.org/jdk/pull/17186


More information about the hotspot-gc-dev mailing list