RFR: 8322537: Parallel: Remove experimental adjustment in PSAdaptiveSizePolicy

[Thomas Schatzl]

On Thu, 11 Jan 2024 08:58:18 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>>> Removing this setter (and other similar ones) changes the values of the externally observable performance counters. Not sure if this has been intended.
>> 
>> Yes, that is intended. That perf-counter lives in the "unstable and unsupported name space" (https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/perfData.cpp#L56).
>> 
>> Having the indicated action recorded in the perf-counter was probably used to aid the development of AdaptiveSizePolicy. However, its existence solely complicates the flow nowadays. Therefore, I propose removing it completely. (Ofc, one can always perform another round of experiment to improve AdaptiveSizePolicy afterwards.)
>
> I am okay with removing the counter after a quick search if it seems to be used, but if so I would prefer to remove it completely not only the counter updates.
> That at least sends a clear signal that the counter is not available any more to anyone actually using it; silently returning garbage seems worse service to users.

s/used/unused ; (I can't imagine anyone uses it for something useful)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17166#discussion_r1448542596