RFR: 8322537: Parallel: Remove experimental adjustment in PSAdaptiveSizePolicy

Thomas Schatzl tschatzl at openjdk.org
Thu Jan 11 12:31:32 UTC 2024


On Thu, 11 Jan 2024 09:20:46 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> I am okay with removing the counter after a quick search if it seems to be used, but if so I would prefer to remove it completely not only the counter updates.
>> That at least sends a clear signal that the counter is not available any more to anyone actually using it; silently returning garbage seems worse service to users.
>
> s/used/unused ; (I can't imagine anyone uses it for something useful)

After going through the code with Albert I am okay with the changes; so these values set here (e.g. the `increase_young_gen_for_min_pauses_true`) never showed up anywhere but in the perf counters; there were no corresponding log messages ever, and one could argue that removing these particular perf counter updates aligns them to what the log output shows.
It's somewhat subjective whether aligning the log messages to the perf counters or the perf counters to the log messages is more correct, and I do not have a preference either way.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17166#discussion_r1448779358


More information about the hotspot-gc-dev mailing list