RFR: 8234502: Merge GenCollectedHeap and SerialHeap [v12]

Chris Plummer cjplummer at openjdk.org
Thu Jan 11 21:17:35 UTC 2024


On Thu, 11 Jan 2024 18:30:33 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Lei Zaakjyu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   restore and rename 'GenCollectedHeap' to 'SerialHeap'
>
> src/hotspot/share/gc/shared/vmStructs_gc.hpp line 180:
> 
>> 178:   declare_toplevel_type(DefNewGeneration*)                                \
>> 179:   declare_toplevel_type(GenCollectedHeap*)                                \
>> 180:   declare_toplevel_type(Generation*)                                      \
> 
> You need to restore these lines and rename GenCollectedHeap -> SerialHeap. I'm not sure why DefNewGeneration and Generation were deleted. I assume they are still present.

It looks like all 3 of these already exist elsewhere, thus their removal is ok.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16927#discussion_r1449402502


More information about the hotspot-gc-dev mailing list