RFR: 8323779: Serial: Remove Generation::promotion_attempt_is_safe

[Stefan Karlsson]

On Tue, 16 Jan 2024 09:16:08 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple updating a field type to use more concrete type.

src/hotspot/share/gc/serial/defNewGeneration.hpp line 56:

> 54:   friend class VMStructs;
> 55: 
> 56:   TenuredGeneration* _old_gen;

The alignment in this block is weird after this change.

src/hotspot/share/gc/serial/tenuredGeneration.hpp line 163:

> 161:   // Promotion of the full amount is not guaranteed but
> 162:   // might be attempted in the worst case.
> 163:   bool promotion_attempt_is_safe(size_t max_promoted_in_bytes) const;

Could you move this declaration up above the `// Performance Counter Support`, so that it doesn't look like this function blongs to the `// Statistics` section?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17439#discussion_r1453191761
PR Review Comment: https://git.openjdk.org/jdk/pull/17439#discussion_r1453194103