RFR: 8323779: Serial: Remove Generation::promotion_attempt_is_safe

Stefan Karlsson stefank at openjdk.org
Tue Jan 16 10:04:24 UTC 2024


On Tue, 16 Jan 2024 10:00:08 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Simple updating a field type to use more concrete type.
>
> src/hotspot/share/gc/serial/tenuredGeneration.hpp line 163:
> 
>> 161:   // Promotion of the full amount is not guaranteed but
>> 162:   // might be attempted in the worst case.
>> 163:   bool promotion_attempt_is_safe(size_t max_promoted_in_bytes) const;
> 
> Could you move this declaration up above the `// Performance Counter Support`, so that it doesn't look like this function blongs to the `// Statistics` section?

Never mind. I see that it wasn't your change that placed it there.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17439#discussion_r1453195563


More information about the hotspot-gc-dev mailing list