RFR: 8318682: SA decoding of scalar replaced objects is broken [v4]

[Tom Rodriguez]

On Tue, 16 Jan 2024 22:36:55 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Tom Rodriguez has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/NMethod.java
>>    
>>    Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>>  - Update src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java
>>    
>>    Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java line 1644:
> 
>> 1642:             }
>> 1643:         },
>> 1644:         new Command("testdebuginfodecode", "testdebuginfodecode", false) {
> 
> This doesn't belong in clhsdb. You can do all of this directly in the test if you launch it properly. 
> See for example `TestObjectAlignment.java`.

Yes that's much better.  I've updated the test and renamed it.  Please rereview.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17407#discussion_r1456153937