RFR: 8318682: SA decoding of scalar replaced objects is broken [v4]

[Chris Plummer]

On Tue, 16 Jan 2024 22:47:04 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Tom Rodriguez has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/NMethod.java
>>    
>>    Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>>  - Update src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java
>>    
>>    Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>
> test/hotspot/jtreg/serviceability/sa/ClhsdbTestAllocationMerge.java line 58:
> 
>> 56:             Map<String, List<String>> expStrMap = new HashMap<>();
>> 57:             Map<String, List<String>> unExpStrMap = new HashMap<>();
>> 58:             test.run(theApp.getPid(), cmds, expStrMap, unExpStrMap);
> 
> You can just pass `null` for the two Map args, and no need to import java.util.HashMap or java.util.Map.

This still needs to be taken care of.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17407#discussion_r1456380163