RFR: 8323685: PrintSystemDictionaryAtExit has mutex rank assert

Thomas Schatzl tschatzl at openjdk.org
Fri Jan 19 10:30:28 UTC 2024


On Wed, 17 Jan 2024 22:55:30 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> Use variant 2 change from PR https://github.com/openjdk/jdk/pull/16062 that allows the ConcurrentHashTable to specify lock ranking for the resize lock at construction.  SystemDictionary printing takes out both CHT resize lock and the ttyLocker.
> 
> Tested with tier1-7, special stress test in tier7 to verify JDK-8317440 is still fixed.

Seems to be just like that suggestion in #16062.

Feel free to ignore the other comment, at least I try to avoid extra files if not necessary.

test/hotspot/jtreg/runtime/PrintingTests/SampleClass.java line 29:

> 27:         System.out.println("Hello from the sample class");
> 28:     }
> 29: }

My recommendation to decrease the amount of noise would be to put this class into the other test file, and use `SampleClass.class.getname()` to use in `ProcessTools`.
Avoids an extra file and an extra copyright header...

-------------

Marked as reviewed by tschatzl (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17471#pullrequestreview-1832096672
PR Review Comment: https://git.openjdk.org/jdk/pull/17471#discussion_r1458744224


More information about the hotspot-gc-dev mailing list