RFR: 8323685: PrintSystemDictionaryAtExit has mutex rank assert [v2]

Coleen Phillimore coleenp at openjdk.org
Fri Jan 19 14:20:45 UTC 2024


On Fri, 19 Jan 2024 10:26:22 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fold SampleClass into printing test.
>
> test/hotspot/jtreg/runtime/PrintingTests/SampleClass.java line 29:
> 
>> 27:         System.out.println("Hello from the sample class");
>> 28:     }
>> 29: }
> 
> My recommendation to decrease the amount of noise would be to put this class into the other test file, and use `SampleClass.class.getname()` to use in `ProcessTools`.
> Avoids an extra file and an extra copyright header...

Thanks for the suggestion, it's much better.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17471#discussion_r1459075548


More information about the hotspot-gc-dev mailing list