RFR: 8323685: PrintSystemDictionaryAtExit has mutex rank assert [v2]

Thomas Stuefe stuefe at openjdk.org
Fri Jan 19 15:56:29 UTC 2024


On Fri, 19 Jan 2024 15:33:44 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fold SampleClass into printing test.
>
> src/hotspot/share/utilities/concurrentHashTable.hpp line 410:
> 
>> 408:                       size_t grow_hint = DEFAULT_GROW_HINT,
>> 409:                       bool enable_statistics = DEFAULT_ENABLE_STATISTICS,
>> 410:                       Mutex::Rank rank = Mutex::nosafepoint-2,
> 
> This is the default rank.  It seems reasonable to not stop for safepoints with the resizing lock (since it's the lock taken while in a safepoint - do_safepoint_scan).  This was the default before it was lowered to service-1.

Ah. Sorry for missing it. I was thrown off by the explicit constructor below and the different order of arguments.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17471#discussion_r1459240942


More information about the hotspot-gc-dev mailing list