RFR: 8323685: PrintSystemDictionaryAtExit has mutex rank assert [v2]

Coleen Phillimore coleenp at openjdk.org
Fri Jan 19 16:13:33 UTC 2024


On Fri, 19 Jan 2024 15:53:31 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> src/hotspot/share/utilities/concurrentHashTable.hpp line 410:
>> 
>>> 408:                       size_t grow_hint = DEFAULT_GROW_HINT,
>>> 409:                       bool enable_statistics = DEFAULT_ENABLE_STATISTICS,
>>> 410:                       Mutex::Rank rank = Mutex::nosafepoint-2,
>> 
>> This is the default rank.  It seems reasonable to not stop for safepoints with the resizing lock (since it's the lock taken while in a safepoint - do_safepoint_scan).  This was the default before it was lowered to service-1.
>
> Ah. Sorry for missing it. I was thrown off by the explicit constructor below and the different order of arguments.

It took me while to find it from Thomas's original patch too.  Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17471#discussion_r1459266735


More information about the hotspot-gc-dev mailing list