RFR: 8324649: Shenandoah: refactor implementation of free set [v2]

[Kelvin Nilsen]

On Fri, 26 Jan 2024 17:46:37 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unnecessary change related to debugging
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 34:
> 
>> 32: 
>> 33: enum ShenandoahFreeMemoryType : uint8_t {
>> 34:   NotFree,
> 
> Can you motivate why a FreeMemoryType should have a value NotFree? If so, then you want to call it RegionType, rather than FreeMemoryType.
> 
> I'd also write a brief line/phrase of documentation about the intent of each of the defined types of (region/free memory) used here.

Thanks for your feedback.  I'm adding comments on these declarations.

Replacing ShenandoahFreeMemoryType with ShenandoahFreeSetRegionType.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1472064054