RFR: 8324649: Shenandoah: refactor implementation of free set [v2]

[Y. Srinivas Ramakrishna]

On Tue, 30 Jan 2024 22:35:45 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 34:
>> 
>>> 32: 
>>> 33: enum ShenandoahFreeMemoryType : uint8_t {
>>> 34:   NotFree,
>> 
>> Can you motivate why a FreeMemoryType should have a value NotFree? If so, then you want to call it RegionType, rather than FreeMemoryType.
>> 
>> I'd also write a brief line/phrase of documentation about the intent of each of the defined types of (region/free memory) used here.
>
> Thanks for your feedback.  I'm adding comments on these declarations.
> 
> Replacing ShenandoahFreeMemoryType with ShenandoahFreeSetRegionType.

Sorry I wasn't clear. My question was about the "Free" in the name of the type, as if it represented subtypes of "FreeRegions". But since it includes "NotFree", it includes regions that aren't free. May be "RegionFreenessType" if you want free in the name. Then "NotFree" is lack of freeness :-)

But may be I am nitpicking too much here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1473207448