RFR: 8334513: New test gc/TestAlwaysPreTouchBehavior.java is failing [v2]

[Thomas Stuefe]

On Mon, 1 Jul 2024 12:30:31 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Why the explicit -Xmx64m? As I understand this is essentially the launcher, whose heap-size is of little importance.

No particular reason, just don't like launchers to use large heaps. I can remove it.

> Also, why does the launch require WhiteBoxAPI?

Because the launcher needs to access hostAvailableMemory in order to decide before starting the test whether it makes sense to start the test.

> test/hotspot/jtreg/gc/TestAlwaysPreTouchBehavior.java line 161:
> 
>> 159:         System.out.println("RSS: " + rss + " available: " + avail + " committed " + committed);
>> 160: 
>> 161:         if (args[0].equals("run")) {
> 
> When will this branch be taken? I can't find where the `run` arg is specified.

See line 141

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19803#discussion_r1660988240
PR Review Comment: https://git.openjdk.org/jdk/pull/19803#discussion_r1660985382