RFR: 8334513: New test gc/TestAlwaysPreTouchBehavior.java is failing [v2]

[Albert Mingkun Yang]

On Mon, 1 Jul 2024 12:37:03 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> just don't like launchers to use large heaps.

Could you add a comment at the start of this file explaining the test setup, launcher creating another VM + real test flags? There, the rational for small heap (64M) can be covered as well.

Some text on these fields can also help understand this test.

    final static long expectedMaxNonHeapRSS = M * 256;
    final static  long requiredAvailableBefore = heapsize * 2 + expectedMaxNonHeapRSS;
    final static  long requiredAvailableDuring = expectedMaxNonHeapRSS;

>> test/hotspot/jtreg/gc/TestAlwaysPreTouchBehavior.java line 161:
>> 
>>> 159:         System.out.println("RSS: " + rss + " available: " + avail + " committed " + committed);
>>> 160: 
>>> 161:         if (args[0].equals("run")) {
>> 
>> When will this branch be taken? I can't find where the `run` arg is specified.
>
> See line 141

I see; thanks. Can you add a comment referencing `prepareOptions`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19803#discussion_r1661021604
PR Review Comment: https://git.openjdk.org/jdk/pull/19803#discussion_r1661022484