RFR: 8335493: check_gc_overhead_limit should reset SoftRefPolicy::_should_clear_all_soft_refs [v2]
Kim Barrett
kbarrett at openjdk.org
Fri Jul 5 08:36:22 UTC 2024
On Thu, 4 Jul 2024 05:31:28 GMT, Liang Mao <lmao at openjdk.org> wrote:
>> It's for fixing the issue should_clear_all_soft_refs is not reset after Parallel Full GC.
>>
>> Tested test/hotspot/jtreg/gc with -XX:+UseParallelGC
>
> Liang Mao has updated the pull request incrementally with one additional commit since the last revision:
>
> reset in check_gc_overhead_limit
At a quick glance it looks okay, but I've not looked at it carefully enough to say I've reviewed it. Given the amount of
discussion I can't agree with it being "trivial". Small, yes, but with potentially significant impact. And HotSpot rules
around trivial changes and bypassing some of the review process requires agreement by the Reviewer, of which
there is none recorded in the discussion here.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19982#issuecomment-2210442773
More information about the hotspot-gc-dev
mailing list