RFR: 8335904: Fix invalid comment in ShenandoahLock
Aleksey Shipilev
shade at openjdk.org
Mon Jul 8 17:48:34 UTC 2024
On Mon, 8 Jul 2024 16:43:00 GMT, Xiaolong Peng <xpeng at openjdk.org> wrote:
> Hi all,
> This PR is to fix an invalid comment in ShenandoahLock I introduced in https://github.com/openjdk/jdk/pull/19570/files#r1668249587, thank you turbanoff@ for catching this, it is easy to miss since the PR had been closed.
> This PR should be trivial.
>
> Best,
> Xiaolong.
This looks okay.
src/hotspot/share/gc/shenandoah/shenandoahLock.cpp line 47:
> 45: void ShenandoahLock::contended_lock_internal(JavaThread* java_thread) {
> 46: assert(!ALLOW_BLOCK || java_thread != nullptr, "Must have a Java thread when allowing block.");
> 47: // Spin this much on multi-processor, do not spin on single-processor.
I think the proper nomenclature is "uniprocessor". We can avoid all this if we say e.g. "// Spin this much, but only on multi-processor systems"
-------------
Marked as reviewed by shade (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20079#pullrequestreview-2163983319
PR Review Comment: https://git.openjdk.org/jdk/pull/20079#discussion_r1669040268
More information about the hotspot-gc-dev
mailing list