RFR: 8335904: Fix invalid comment in ShenandoahLock [v2]
Xiaolong Peng
xpeng at openjdk.org
Mon Jul 8 18:29:02 UTC 2024
On Mon, 8 Jul 2024 17:43:34 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update comments
>
> src/hotspot/share/gc/shenandoah/shenandoahLock.cpp line 47:
>
>> 45: void ShenandoahLock::contended_lock_internal(JavaThread* java_thread) {
>> 46: assert(!ALLOW_BLOCK || java_thread != nullptr, "Must have a Java thread when allowing block.");
>> 47: // Spin this much on multi-processor, do not spin on single-processor.
>
> I think the proper nomenclature is "uniprocessor". We can avoid all this if we say e.g. "// Spin this much, but only on multi-processor systems"
Thanks, suggestion is taken, I updated the PR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20079#discussion_r1669092329
More information about the hotspot-gc-dev
mailing list