RFR: 8334147: Shenandoah: Avoid taking lock for disabled free set logging [v8]
Y. Srinivas Ramakrishna
ysr at openjdk.org
Thu Jun 27 20:55:51 UTC 2024
On Thu, 27 Jun 2024 20:37:12 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> Xiaolong Peng has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Accidentally removed a empty line
>> - Method renaming
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 344:
>
>> 342: void recycle_trash();
>> 343: void log_status();
>> 344: void log_status_under_lock();
>
> Add a brief 1-line documentation comment for each of the methods, mentioning the preconditions & what they do.
I forgot. Shouldn't `log_status` remove the enablement check, and assert that logging is enabled?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19915#discussion_r1657797139
More information about the hotspot-gc-dev
mailing list