RFR: 8327238: Remove MetadataAllocationFailALot* develop flags

[Guoxiong Li]

On Wed, 6 Mar 2024 09:29:58 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   please review this trivial removal of the `MetadataFailAlot` flags; one of them,
> `MetadataAllocationFailALotInterval` is unused anyway, and the other `MetadataAllocationFailALot` only prevents the attempt to retry metadata allocation in the VM operation.
> 
> This functionality does not seem to stress metadata allocation failure at all, just execution of the metadata VM operation, so I decided to just drop the second flag as well.
> 
> I considered keeping it maybe as `MetadataAllocationFailRetry` or something, but decided against it since it does not seem interesting to test. However I can at reviewer's request do that.
> 
> Testing: local compilation, gha, grepping hotspot tests/hotspot sources
> 
> Thanks,
>   Thomas

LGTM.

-------------

Marked as reviewed by gli (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18133#pullrequestreview-1919452842