RFR: 8327238: Remove MetadataAllocationFailALot* develop flags

[Thomas Schatzl]

On Wed, 6 Mar 2024 11:13:01 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>>   please review this trivial removal of the `MetadataFailAlot` flags; one of them,
>> `MetadataAllocationFailALotInterval` is unused anyway, and the other `MetadataAllocationFailALot` only prevents the attempt to retry metadata allocation in the VM operation.
>> 
>> This functionality does not seem to stress metadata allocation failure at all, just execution of the metadata VM operation, so I decided to just drop the second flag as well.
>> 
>> I considered keeping it maybe as `MetadataAllocationFailRetry` or something, but decided against it since it does not seem interesting to test. However I can at reviewer's request do that.
>> 
>> Testing: local compilation, gha, grepping hotspot tests/hotspot sources
>> 
>> Thanks,
>>   Thomas
>
> LGTM.

Thanks @lgxbslgx @albertnetymk for your reviews

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18133#issuecomment-1983564174