RFR: 8328166: Epsilon: 'EpsilonHeap::allocate_work' misuses the parameter 'size' as size in bytes

Aleksey Shipilev shade at openjdk.org
Thu Mar 14 16:24:38 UTC 2024


On Thu, 14 Mar 2024 13:42:45 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> The method `EpsilonHeap::allocate_work` misuses the parameter `size` as size in bytes. Actually, the parameter `size` is size in words. This patch fixes it.
>  
> The test command `make test TEST=test/hotspot/jtreg/gc/epsilon` passed locally.
> 
> Thanks for taking the time to review.
> 
> Best Regards,
> -- Guoxiong

Right, good catch! This looks like a day 1 Epsilon issue, and we never noticed, because it really matters only for large objects near heap exhaustion.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18303#pullrequestreview-1937186436


More information about the hotspot-gc-dev mailing list