RFR: 8328166: Epsilon: 'EpsilonHeap::allocate_work' misuses the parameter 'size' as size in bytes

Guoxiong Li gli at openjdk.org
Fri Mar 15 03:59:39 UTC 2024


On Thu, 14 Mar 2024 16:22:08 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Hi all,
>> 
>> The method `EpsilonHeap::allocate_work` misuses the parameter `size` as size in bytes. Actually, the parameter `size` is size in words. This patch fixes it.
>>  
>> The test command `make test TEST=test/hotspot/jtreg/gc/epsilon` passed locally.
>> 
>> Thanks for taking the time to review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> Right, good catch! This looks like a day 1 Epsilon issue, and we never noticed, because it really matters only for large objects near heap exhaustion.

Thanks @shipilev for your review. Waiting for another review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18303#issuecomment-1998893442


More information about the hotspot-gc-dev mailing list