RFR: 8328112: Remove CardTable::_guard_region [v3]

Guoxiong Li gli at openjdk.org
Fri Mar 15 13:55:08 UTC 2024


On Fri, 15 Mar 2024 13:46:30 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Do you want to leave `size_t num_bytes = num_cards;`? May it be strange? We already have the comment to clarify it.
>
>> Do you want to leave size_t num_bytes = num_cards;?
> 
> Yes. That comment is for why the conversion factor is one and the unit conversion is explicit. Otherwise, the conversion occurs as the arg is passed `compute_byte_map_size`, which can be confusing and error-prone, IMO.

Ohh, the method `compute_byte_map_size` takes the number of bytes as its parameter. Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18324#discussion_r1526321706


More information about the hotspot-gc-dev mailing list